From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH v2 1/8] kvm tools: Use correct value for user signal base Date: Mon, 30 May 2011 11:40:34 +0300 Message-ID: <1306744834.14564.40.camel@lappy> References: <1306744247-26051-1-git-send-email-levinsasha928@gmail.com> <20110530083523.GD30513@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Ingo Molnar Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:62702 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041Ab1E3IlI (ORCPT ); Mon, 30 May 2011 04:41:08 -0400 Received: by wwa36 with SMTP id 36so3683783wwa.1 for ; Mon, 30 May 2011 01:41:07 -0700 (PDT) In-Reply-To: <20110530083523.GD30513@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2011-05-30 at 10:35 +0200, Ingo Molnar wrote: > * Sasha Levin wrote: > > > Signed-off-by: Sasha Levin > > --- > > tools/kvm/include/kvm/kvm.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/tools/kvm/include/kvm/kvm.h b/tools/kvm/include/kvm/kvm.h > > index f951f2d..6a17362 100644 > > --- a/tools/kvm/include/kvm/kvm.h > > +++ b/tools/kvm/include/kvm/kvm.h > > @@ -11,7 +11,7 @@ > > #define KVM_32BIT_GAP_SIZE (512 << 20) > > #define KVM_32BIT_GAP_START ((1ULL << 32) - KVM_32BIT_GAP_SIZE) > > > > -#define SIGKVMEXIT (SIGUSR1 + 2) > > +#define SIGKVMEXIT (SIGRTMIN + 0) > > I think the changelog is missing essential information like what the > effects of this bug were in practice. ('none' is a good answer as > well.) None - It made us exit when receiving SIGUSR2, which wasn't in use at that time (Now it's used to pause the guest - thats how I found it). -- Sasha.