From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2 2/8] kvm tools: Remove wrong global definition of kvm
Date: Mon, 30 May 2011 11:59:18 +0300
Message-ID: <1306745958.14564.45.camel@lappy>
References: <1306744247-26051-1-git-send-email-levinsasha928@gmail.com>
	 <1306744247-26051-2-git-send-email-levinsasha928@gmail.com>
	 <20110530083821.GE30513@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: penberg@kernel.org, kvm@vger.kernel.org, asias.hejun@gmail.com,
	gorcunov@gmail.com, prasadjoshi124@gmail.com
To: Ingo Molnar <mingo@elte.hu>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:38840 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753003Ab1E3I7s (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 30 May 2011 04:59:48 -0400
Received: by wya21 with SMTP id 21so2475660wya.19
        for <kvm@vger.kernel.org>; Mon, 30 May 2011 01:59:47 -0700 (PDT)
In-Reply-To: <20110530083821.GE30513@elte.hu>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2011-05-30 at 10:38 +0200, Ingo Molnar wrote:
> * Sasha Levin <levinsasha928@gmail.com> wrote:
> 
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> > ---
> >  tools/kvm/include/kvm/mptable.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/tools/kvm/include/kvm/mptable.h b/tools/kvm/include/kvm/mptable.h
> > index 3c8362d..8557ae8 100644
> > --- a/tools/kvm/include/kvm/mptable.h
> > +++ b/tools/kvm/include/kvm/mptable.h
> > @@ -1,7 +1,7 @@
> >  #ifndef KVM_MPTABLE_H_
> >  #define KVM_MPTABLE_H_
> >  
> > -struct kvm kvm;
> > +struct kvm;
> 
> heh, that was a funny typo.
> 
> Btw., could we do a 'make test' run that includes every header file 
> in a standalone .c file and checks whether that builds without 
> warnings/errors? They are enumerated in the Makefile already.

They're not - we need to get it done first.

> That would check tools/kvm/ headers for sanity, type encapsulaion and 
> self-sufficiently and would prevent the kind of header-dependencies 
> spaghetti mess the kernel got into after ~20 years of randomly added 
> kernel dependencies.
> 
> Thanks,
> 
> 	Ingo

-- 

Sasha.