From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] kvm tools, vesa: Use guest-mapped memory for framebuffer Date: Mon, 06 Jun 2011 16:58:57 +0300 Message-ID: <1307368737.27309.8.camel@jaguar> References: <1307368315-10809-1-git-send-email-penberg@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Cyrill Gorcunov , Ingo Molnar , John Floren , Sasha Levin To: Alexander Graf Return-path: Received: from filtteri2.pp.htv.fi ([213.243.153.185]:38141 "EHLO filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755273Ab1FFN67 (ORCPT ); Mon, 6 Jun 2011 09:58:59 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2011-06-06 at 15:56 +0200, Alexander Graf wrote: > > @@ -216,7 +216,7 @@ void kvm__init_ram(struct kvm *kvm) > > phys_size = kvm->ram_size - phys_size; > > host_mem = kvm->ram_start + phys_start; > > > > - kvm_register_mem_slot(kvm, 1, phys_start, phys_size, host_mem); > > + kvm__register_mem_slot(kvm, 1, phys_start, phys_size, host_mem); > > ... and also slot 1. Is this on purpose or could there be potential overwriting? No, I just made a mess out of it and realized it too late. See v2 of the patch I sent just now.