From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH v2 10/11] KVM: x86 emulator: fix RDPMC privilege check
Date: Mon, 13 Jun 2011 16:35:05 +0300 [thread overview]
Message-ID: <1307972106-2468-11-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1307972106-2468-1-git-send-email-avi@redhat.com>
RDPMC is only privileged if CR4.PCE=0. check_rdpmc() already implements this,
so all we need to do is drop the Priv flag.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
arch/x86/kvm/emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 14891ad..51804fd 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -3218,7 +3218,7 @@ static struct opcode twobyte_table[256] = {
DI(ImplicitOps | Priv, wrmsr),
IIP(ImplicitOps, em_rdtsc, rdtsc, check_rdtsc),
DI(ImplicitOps | Priv, rdmsr),
- DIP(ImplicitOps | Priv, rdpmc, check_rdpmc),
+ DIP(ImplicitOps, rdpmc, check_rdpmc),
I(ImplicitOps | VendorSpecific, em_sysenter),
I(ImplicitOps | Priv | VendorSpecific, em_sysexit),
N, N,
--
1.7.5.3
next prev parent reply other threads:[~2011-06-13 13:35 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 13:34 [PATCH v2 00/11] KVM in-guest performance monitoring Avi Kivity
2011-06-13 13:34 ` [PATCH v2 01/11] perf: add context field to perf_event Avi Kivity
2011-06-13 13:34 ` [PATCH v2 02/11] x86, perf: add constraints for architectural PMU v1 Avi Kivity
2011-06-13 13:34 ` [PATCH v2 03/11] perf: export perf_event_refresh() to modules Avi Kivity
2011-06-13 13:34 ` [PATCH v2 04/11] KVM: Expose kvm_lapic_local_deliver() Avi Kivity
2011-06-13 13:35 ` [PATCH v2 05/11] KVM: Expose a version 1 architectural PMU to guests Avi Kivity
2011-06-13 18:10 ` David Ahern
2011-06-14 8:33 ` Avi Kivity
2011-06-27 14:10 ` lidong chen
2011-06-27 14:13 ` Avi Kivity
2011-06-28 2:54 ` lidong chen
2011-06-28 8:15 ` Avi Kivity
2011-06-13 13:35 ` [PATCH v2 06/11] KVM: Add generic RDPMC support Avi Kivity
2011-06-13 13:35 ` [PATCH v2 07/11] KVM: SVM: Intercept RDPMC Avi Kivity
2011-06-13 13:35 ` [PATCH v2 08/11] KVM: VMX: " Avi Kivity
2011-06-13 16:17 ` David Ahern
2011-06-13 16:29 ` Avi Kivity
2011-06-13 16:59 ` David Ahern
2011-06-13 17:38 ` Ingo Molnar
2011-06-13 18:09 ` David Ahern
2011-06-14 8:34 ` Avi Kivity
2011-06-14 9:27 ` Ingo Molnar
2011-06-13 13:35 ` [PATCH v2 09/11] KVM: Expose the architectural performance monitoring CPUID leaf Avi Kivity
2011-06-13 13:35 ` Avi Kivity [this message]
2011-06-13 13:35 ` [PATCH v2 11/11] KVM: x86 emulator: implement RDPMC (0F 33) Avi Kivity
2011-06-13 19:55 ` [PATCH v2 00/11] KVM in-guest performance monitoring David Ahern
2011-06-14 8:36 ` Avi Kivity
2011-06-14 17:15 ` David Ahern
2011-06-14 17:24 ` Jan Kiszka
2011-06-14 17:33 ` David Ahern
2011-06-14 17:48 ` David Ahern
2011-06-14 18:11 ` David Ahern
2011-06-15 8:57 ` Avi Kivity
2011-06-15 12:40 ` David Ahern
2011-06-15 13:22 ` Avi Kivity
2011-06-15 16:08 ` David Ahern
2011-06-15 16:27 ` Avi Kivity
2011-06-15 16:51 ` David Ahern
2011-06-16 13:53 ` Avi Kivity
2011-06-16 14:08 ` David Ahern
2011-06-16 14:19 ` David Ahern
2011-06-16 14:20 ` Avi Kivity
2011-06-16 14:32 ` David Ahern
2011-06-16 14:36 ` Avi Kivity
2011-06-16 15:04 ` David Ahern
2011-06-16 15:08 ` Peter Zijlstra
2011-06-16 15:18 ` David Ahern
2011-06-16 15:19 ` David Ahern
2011-06-16 15:27 ` Peter Zijlstra
2011-06-16 15:34 ` David Ahern
2011-06-16 15:59 ` Avi Kivity
2011-06-16 16:04 ` David Ahern
2011-06-16 16:31 ` Avi Kivity
2011-06-16 17:16 ` David Ahern
2011-06-29 7:52 ` Avi Kivity
2011-06-29 8:38 ` Peter Zijlstra
2011-06-29 9:26 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307972106-2468-11-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox