From: Sasha Levin <levinsasha928@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: penberg@kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers
Date: Fri, 17 Jun 2011 15:45:06 -0400 [thread overview]
Message-ID: <1308339906.8711.13.camel@lappy> (raw)
In-Reply-To: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote:
> Otherwise many things can break, such as mapping of stat to stat64
We always include our headers before system headers to make sure we
don't have any hidden prerequisites or dependencies within the headers.
Why did you need to move system headers before our headers in this case?
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> tools/kvm/virtio/9p.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
--
Sasha.
next prev parent reply other threads:[~2011-06-17 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 18:11 [PATCH 1/2] tools/kvm/9p: Always include system header before our headers Aneesh Kumar K.V
2011-06-17 18:11 ` [PATCH 2/2] tools/kvm/9p: Add support for multiple 9p export dirs Aneesh Kumar K.V
2011-06-17 20:06 ` Sasha Levin
2011-06-17 19:45 ` Sasha Levin [this message]
2011-06-17 19:47 ` [PATCH 1/2] tools/kvm/9p: Always include system header before our headers Pekka Enberg
2011-06-18 6:48 ` Aneesh Kumar K.V
2011-06-18 7:07 ` Aneesh Kumar K.V
2011-06-18 7:50 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308339906.8711.13.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox