From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers Date: Fri, 17 Jun 2011 15:45:06 -0400 Message-ID: <1308339906.8711.13.camel@lappy> References: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, kvm@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:65482 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932949Ab1FQTpK (ORCPT ); Fri, 17 Jun 2011 15:45:10 -0400 Received: by qwk3 with SMTP id 3so91794qwk.19 for ; Fri, 17 Jun 2011 12:45:10 -0700 (PDT) In-Reply-To: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote: > Otherwise many things can break, such as mapping of stat to stat64 We always include our headers before system headers to make sure we don't have any hidden prerequisites or dependencies within the headers. Why did you need to move system headers before our headers in this case? > > Signed-off-by: Aneesh Kumar K.V > --- > tools/kvm/virtio/9p.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) -- Sasha.