From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers Date: Fri, 17 Jun 2011 22:47:39 +0300 Message-ID: <1308340059.28516.3.camel@jaguar> References: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308339906.8711.13.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "Aneesh Kumar K.V" , kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from filtteri1.pp.htv.fi ([213.243.153.184]:56408 "EHLO filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757834Ab1FQTrl (ORCPT ); Fri, 17 Jun 2011 15:47:41 -0400 In-Reply-To: <1308339906.8711.13.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2011-06-17 at 15:45 -0400, Sasha Levin wrote: > On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote: > > Otherwise many things can break, such as mapping of stat to stat64 > > We always include our headers before system headers to make sure we > don't have any hidden prerequisites or dependencies within the headers. > > Why did you need to move system headers before our headers in this case? The stat64() breakage seems rather odd since we do this in the Makefile: DEFINES += -D_FILE_OFFSET_BITS=64 DEFINES += -D_GNU_SOURCE Aneesh, what kind of build problems are you seeing?