From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 4/5] tools/kvm/9p: Fix the pdu len. Date: Sat, 18 Jun 2011 14:51:19 -0400 Message-ID: <1308423079.3766.7.camel@lappy> References: <1308419348-31934-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308419348-31934-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, kvm@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:47088 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028Ab1FRSvW (ORCPT ); Sat, 18 Jun 2011 14:51:22 -0400 Received: by vxb39 with SMTP id 39so162271vxb.19 for ; Sat, 18 Jun 2011 11:51:21 -0700 (PDT) In-Reply-To: <1308419348-31934-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, 2011-06-18 at 23:19 +0530, Aneesh Kumar K.V wrote: > The TSTAT output formwat is wS. So not sure whey we > need sizeof(u16)*2 in pdu length. See http://ericvh.github.com/9p-rfc/rfc9p2000.html#anchor32 "BUGS To make the contents of a directory, such as returned by read(5), easy to parse, each directory entry begins with a size field. For consistency, the entries in Twstat and Rstat messages also contain their size, which means the size appears twice. For example, the Rstat message is formatted as ``(4+1+2+2+n)[4] Rstat tag[2] n[2] (n-2)[2] type[2] dev[4]...,'' where n is the value returned by convD2M." > Signed-off-by: Aneesh Kumar K.V > --- > tools/kvm/virtio/9p.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c > index 3172c1a..ef2fbaf 100644 > --- a/tools/kvm/virtio/9p.c > +++ b/tools/kvm/virtio/9p.c > @@ -458,7 +458,7 @@ static bool virtio_p9_stat(struct p9_dev *p9dev, struct p9_msg *msg, > > ret = virtio_p9_fill_stat(p9dev, fid->path, &st, rstat); > > - *outlen = VIRTIO_P9_HDR_LEN + ret + sizeof(u16) * 2; > + *outlen = VIRTIO_P9_HDR_LEN + ret + sizeof(u16); > set_p9msg_hdr(outmsg, *outlen, P9_RSTAT, msg->tag); > return true; > } -- Sasha.