From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 5/5] tools/kvm/9p: Simplify the handler Date: Sun, 19 Jun 2011 02:41:59 -0400 Message-ID: <1308465719.2899.18.camel@lappy> References: <1308419348-31934-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308419348-31934-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308423094.3766.8.camel@lappy> <87fwn61jze.fsf@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, kvm@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:35266 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524Ab1FSGmC (ORCPT ); Sun, 19 Jun 2011 02:42:02 -0400 Received: by qyk9 with SMTP id 9so658822qyk.19 for ; Sat, 18 Jun 2011 23:42:01 -0700 (PDT) In-Reply-To: <87fwn61jze.fsf@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2011-06-19 at 10:43 +0530, Aneesh Kumar K.V wrote: > On Sat, 18 Jun 2011 14:51:34 -0400, Sasha Levin wrote: > > On Sat, 2011-06-18 at 23:19 +0530, Aneesh Kumar K.V wrote: > > > Signed-off-by: Aneesh Kumar K.V > > > --- > > > tools/kvm/include/net/9p/9p.h | 1 - > > > tools/kvm/virtio/9p.c | 261 +++++++++++++++++++++++------------------ > > > 2 files changed, 147 insertions(+), 115 deletions(-) > > > > After applying the patches (within a 9p mounted dir): > > > > # mkdir new_dir > > # cp 10MB new_dir/ > > cp: cannot create regular file `new_dir/10MB': No such file or directory > > > > works fine here > > sh-2.05b# ls -al 10M > -rwxr-xr-x 1 4294967294 4294967294 10485760 Jun 19 2011 10M > sh-2.05b# mkdir new_dir > sh-2.05b# cp 10M new_dir/ > sh-2.05b# > > Can you check the before and after behaviour with the patch ? It works ok before the patch here. I've added debug to the mount command, looks like it was caused due to patch 4/5 (the removal of one u16) - the host didn't quite like it :) -- Sasha.