From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v3 7/9] KVM-GST: KVM Steal time accounting Date: Thu, 30 Jun 2011 23:54:34 +0200 Message-ID: <1309470874.12449.610.camel@twins> References: <1309361388-30163-1-git-send-email-glommer@redhat.com> <1309361388-30163-8-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Rik van Riel , Jeremy Fitzhardinge , Avi Kivity , Anthony Liguori , Eric B Munson To: Glauber Costa Return-path: In-Reply-To: <1309361388-30163-8-git-send-email-glommer@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 2011-06-29 at 11:29 -0400, Glauber Costa wrote: > +static inline u64 steal_ticks(u64 steal) > +{ > + if (unlikely(steal > NSEC_PER_SEC)) > + return steal / TICK_NSEC; That won't compile on a number of 32bit architecture, use div_u64 or something similar. > + > + return __iter_div_u64_rem(steal, TICK_NSEC, &steal); > +}