From: Sasha Levin <levinsasha928@gmail.com>
To: kvm@vger.kernel.org
Cc: Sasha Levin <levinsasha928@gmail.com>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check
Date: Tue, 5 Jul 2011 02:09:13 +0300 [thread overview]
Message-ID: <1309820954-8629-1-git-send-email-levinsasha928@gmail.com> (raw)
Add a module parameter 'check_inuse' to allow disabling the check of whether
virtualization has already been enabled on the given cpu.
This is needed to deal with broken BIOS which set the SVM/VMX bit by default.
Cc: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Suggested-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
arch/x86/kvm/svm.c | 5 ++++-
arch/x86/kvm/vmx.c | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 475d1c9..5ca76e3 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -183,6 +183,9 @@ module_param(npt, int, S_IRUGO);
static int nested = 1;
module_param(nested, int, S_IRUGO);
+static bool check_inuse = 1;
+module_param(check_inuse, bool, S_IRUGO);
+
static void svm_flush_tlb(struct kvm_vcpu *vcpu);
static void svm_complete_interrupts(struct vcpu_svm *svm);
@@ -587,7 +590,7 @@ static int svm_hardware_enable(void *garbage)
int me = raw_smp_processor_id();
rdmsrl(MSR_EFER, efer);
- if (efer & EFER_SVME)
+ if (check_inuse && (efer & EFER_SVME))
return -EBUSY;
if (!has_svm()) {
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index f5b49c7..3046b07 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -74,6 +74,9 @@ module_param(vmm_exclusive, bool, S_IRUGO);
static int __read_mostly yield_on_hlt = 1;
module_param(yield_on_hlt, bool, S_IRUGO);
+static bool check_inuse = 1;
+module_param(check_inuse, bool, S_IRUGO);
+
/*
* If nested=1, nested virtualization is supported, i.e., guests may use
* VMX and be a hypervisor for its own guests. If nested=0, guests may not
@@ -2230,7 +2233,7 @@ static int hardware_enable(void *garbage)
u64 phys_addr = __pa(per_cpu(vmxarea, cpu));
u64 old, test_bits;
- if (read_cr4() & X86_CR4_VMXE)
+ if (check_inuse && (read_cr4() & X86_CR4_VMXE))
return -EBUSY;
INIT_LIST_HEAD(&per_cpu(loaded_vmcss_on_cpu, cpu));
--
1.7.6
next reply other threads:[~2011-07-04 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 23:09 Sasha Levin [this message]
2011-07-04 23:09 ` [PATCH 2/2] vmx,svm: Print errors if SVM or VMX were already set Sasha Levin
2011-07-05 0:42 ` Alexander Graf
2011-07-05 6:16 ` Tian, Kevin
2011-07-05 6:14 ` Tian, Kevin
2011-07-05 8:09 ` [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check Avi Kivity
2011-07-05 8:14 ` Sasha Levin
2011-07-05 9:11 ` Joerg Roedel
2011-07-05 9:32 ` Sasha Levin
2011-07-05 9:37 ` Avi Kivity
2011-07-05 9:56 ` Sasha Levin
2011-07-05 10:37 ` Avi Kivity
2011-07-05 11:07 ` Sasha Levin
2011-07-05 11:14 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309820954-8629-1-git-send-email-levinsasha928@gmail.com \
--to=levinsasha928@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox