Re: [Qemu-devel] [PATCH 0/4] scsi fixes

Alexander Graf
2011-07-19T08:50:09Z

On 19.07.2011, at 10:10, Hannes Reinecke wrote:

> On 07/19/2011 09:39 AM, Kevin Wolf wrote:
>> Am 19.07.2011 08:31, schrieb Hannes Reinecke:
>>> On 07/12/2011 03:37 PM, Kevin Wolf wrote:
>>>> Am 11.07.2011 15:02, schrieb Hannes Reinecke:
>>>>> Hi all,
>>>>>
>>>>> these are some fixes I found during debugging my megasas HBA emulation.
>>>>> This time I've sent them as a separate patchset for inclusion.
>>>>> All of them have been acked, so please apply.
>>>>>
>>>>> Hannes Reinecke (4):
>>>>> iov: Update parameter usage in iov_(to|from)_buf()
>>>>> scsi: Add 'hba_private' to SCSIRequest
>>>>> scsi-disk: Fixup debugging statement
>>>>> scsi-disk: Mask out serial number EVPD
>>>>
>>>> Thanks, applied all to the block branch.
>>>>
>>> Any chance to have them pulled into the main tree?
>>> My megasas emulation relies on them, and it feels a bit
>>> stupid to send a patch relying on some fixes not in mainline.
>>> At the same time it's really stupid to resend the entire
>>> patchset again ...
>>
>> I'm hoping to send a pull request today, now that the VMDK patches look
>> good finally.
>>
>> Anyway, I don't think that not having the patches in master yet should
>> stop you from going forward with the next patches. They will go through
>> the block tree anyway, so basing them on that tree is fine (and you
>> wouldn't be the first one to do that). Just state in PATCH 0/n for the
>> reviewers that it depends on the other patches.
>>
> Well, the remaining patch is 'just' the megasas emulation itself.
> And I want to make reviewing that as easy as possible, so that it's not again being held off by complains about missing patches.

Yes, no worries. Just state in the patch description that it's based on the block branch and actually do base it on it - the endianness specific ld./st. patches are upstream, so everything you need should be in that branch.

Alex