From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [PATCH] memory: transaction API
Date: Thu, 21 Jul 2011 13:21:19 +0300 [thread overview]
Message-ID: <1311243679-18403-1-git-send-email-avi@redhat.com> (raw)
Allow changes to the memory hierarchy to be accumulated and
made visible all at once. This reduces computational effort,
especially when an accelerator (e.g. kvm) is involved.
Useful when a single register update causes multiple changes
to an address space.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
memory.c | 20 ++++++++++++++++++++
memory.h | 8 ++++++++
2 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/memory.c b/memory.c
index 0ffc905..8780533 100644
--- a/memory.c
+++ b/memory.c
@@ -18,6 +18,8 @@
#include "kvm.h"
#include <assert.h>
+unsigned memory_region_transaction_depth = 0;
+
typedef struct AddrRange AddrRange;
struct AddrRange {
@@ -648,6 +650,10 @@ static void address_space_update_topology(AddressSpace *as)
static void memory_region_update_topology(void)
{
+ if (memory_region_transaction_depth) {
+ return;
+ }
+
if (address_space_memory.root) {
address_space_update_topology(&address_space_memory);
}
@@ -656,6 +662,20 @@ static void memory_region_update_topology(void)
}
}
+void memory_region_transaction_begin(void)
+{
+ ++memory_region_transaction_depth;
+}
+
+void memory_region_transaction_commit(void)
+{
+ if (!memory_region_transaction_depth) {
+ abort();
+ }
+ --memory_region_transaction_depth;
+ memory_region_update_topology();
+}
+
void memory_region_init(MemoryRegion *mr,
const char *name,
uint64_t size)
diff --git a/memory.h b/memory.h
index e4c0ad1..cb3a9b6 100644
--- a/memory.h
+++ b/memory.h
@@ -246,6 +246,14 @@ void memory_region_add_subregion_overlap(MemoryRegion *mr,
void memory_region_del_subregion(MemoryRegion *mr,
MemoryRegion *subregion);
+/* Start a transaction; changes will be accumulated and made visible only
+ * when the transaction ends.
+ */
+void memory_region_transaction_begin(void);
+/* Commit a transaction and make changes visible to the guest.
+ */
+void memory_region_transaction_commit(void);
+
#endif
#endif
--
1.7.5.3
next reply other threads:[~2011-07-21 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 10:21 Avi Kivity [this message]
2011-07-21 10:38 ` [PATCH] memory: transaction API Jan Kiszka
2011-07-21 12:05 ` Avi Kivity
2011-07-21 12:08 ` Avi Kivity
2011-07-21 12:09 ` Jan Kiszka
2011-07-21 12:13 ` Avi Kivity
2011-07-21 12:52 ` Jan Kiszka
2011-07-21 12:58 ` Avi Kivity
2011-07-21 13:17 ` Jan Kiszka
2011-07-21 13:50 ` Avi Kivity
2011-07-21 14:32 ` Jan Kiszka
2011-07-21 14:39 ` Avi Kivity
2011-07-21 15:05 ` Jan Kiszka
2011-07-21 15:11 ` Avi Kivity
2011-07-21 11:04 ` Ferry Huberts
2011-07-21 12:07 ` Avi Kivity
2011-07-21 12:26 ` Ferry Huberts
2011-07-21 12:46 ` Avi Kivity
2011-07-21 12:56 ` Ferry Huberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311243679-18403-1-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox