Re: [PATCH 1/3] kvm tools: add signal placeholder to avoid balloon crash

Sasha Levin
2011-08-11T07:30:06Z

On Thu, 2011-08-11 at 13:07 +0800, Liming Wang wrote:
> If "kvm run" without balloon option, use "kvm balloon" may
> crash kvm. Add signal placeholder to avoid this.
>
> Signed-off-by: Liming Wang <walimisdev@gmail.com>
> ---
> tools/kvm/builtin-run.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> index fa5de27..d725834 100644
> --- a/tools/kvm/builtin-run.c
> +++ b/tools/kvm/builtin-run.c
> @@ -280,6 +280,10 @@ static void handle_sigstop(int sig)
> kvm_cpu__reboot();
> }
>
> +static void handle_empty(int sig)
> +{
> +}
> +
> static void *kvm_cpu_thread(void *arg)
> {
> current_kvm_cpu = arg;
> @@ -469,6 +473,9 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix)
> signal(SIGUSR2, handle_sigusr2);
> signal(SIGKVMSTOP, handle_sigstop);
> signal(SIGKVMRESUME, handle_sigusr2);
> + /* signal placeholder if not enable balloon */
> + signal(SIGKVMADDMEM, handle_empty);

You can just do this:
signal(SIGKVMADDMEM, SIG_IGN);

For both, and avoid the empty handler.

> + signal(SIGKVMDELMEM, handle_empty);
>
> nr_online_cpus = sysconf(_SC_NPROCESSORS_ONLN);
>

--

Sasha.