From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] kvm tools: Use correct size for VESA memory bar Date: Thu, 11 Aug 2011 14:55:32 +0300 Message-ID: <1313063732.3456.11.camel@lappy> References: <1313053448-13315-1-git-send-email-levinsasha928@gmail.com> <1313053448-13315-2-git-send-email-levinsasha928@gmail.com> <20110811094949.GD13190@walimis-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: walimis Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:54611 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753538Ab1HKL4q (ORCPT ); Thu, 11 Aug 2011 07:56:46 -0400 Received: by fxh19 with SMTP id 19so1604929fxh.19 for ; Thu, 11 Aug 2011 04:56:44 -0700 (PDT) In-Reply-To: <20110811094949.GD13190@walimis-desktop> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-08-11 at 17:49 +0800, walimis wrote: > On Thu, Aug 11, 2011 at 12:04:08PM +0300, Sasha Levin wrote: > >This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar. > > > >This fixes wrong output on lspci command and ioremap warnings during boot. > > > >Reported-by: David Evensky > >Signed-off-by: Sasha Levin > >--- > > tools/kvm/hw/serial.c | 2 +- > > tools/kvm/hw/vesa.c | 2 +- > > tools/kvm/pci.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/tools/kvm/hw/serial.c b/tools/kvm/hw/serial.c > >index 1199264..0393d3d 100644 > >--- a/tools/kvm/hw/serial.c > >+++ b/tools/kvm/hw/serial.c > >@@ -213,7 +213,7 @@ static bool serial8250_out(struct ioport *ioport, struct kvm *kvm, u16 port, voi > > case UART_TX: { > > char *addr = data; > > > >- if (!(dev->mcr & UART_MCR_LOOP)) > >+ if (!(dev->mcr & (UART_MCR_LOOP | UART_MCR_OUT2))) > I assume it was your mistake to include this part? > > walimis Heh... yes it was. Thanks :) -- Sasha.