From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path Date: Thu, 11 Aug 2011 16:48:38 +0300 Message-ID: <1313070518.3456.18.camel@lappy> References: <1313066636-28332-1-git-send-email-levinsasha928@gmail.com> <1313070086.3456.17.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Pekka Enberg Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:36852 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033Ab1HKNti (ORCPT ); Thu, 11 Aug 2011 09:49:38 -0400 Received: by fxh19 with SMTP id 19so1673664fxh.19 for ; Thu, 11 Aug 2011 06:49:37 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-08-11 at 16:47 +0300, Pekka Enberg wrote: > On Thu, 11 Aug 2011, Sasha Levin wrote: > >> This is a nice cleanup but I'm not happy about the fact that you also nuke > >> the above printf(). Is there a simple way to keep it there? > >> > > > > You get that printf from the normal exit path. > > You get a different printf: > > $ grep -r "KVM session" *.c > builtin-run.c: printf("\n # KVM session ended normally.\n"); > term.c: printf("\n # KVM session terminated.\n"); > > It's nice to see that the user terminated the session without going > through reboot cycle. Dunno how much it matters but it'd be nice to keep > it since it's already there. Hm... In that case, how about changing it to "# KVM session terminating..." which will be followed by "# KVM session terminated" when the guest is actually dead? -- Sasha.