From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 2/2] kvm tools: Use correct offset for virtio-net config space Date: Fri, 12 Aug 2011 08:25:57 +0300 Message-ID: <1313126757.29737.25.camel@jaguar> References: <1313095311-7413-1-git-send-email-levinsasha928@gmail.com> <1313095311-7413-2-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Sasha Levin Return-path: Received: from filtteri2.pp.htv.fi ([213.243.153.185]:48424 "EHLO filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074Ab1HLFZ7 (ORCPT ); Fri, 12 Aug 2011 01:25:59 -0400 In-Reply-To: <1313095311-7413-2-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-08-11 at 23:41 +0300, Sasha Levin wrote: > This patch fixes the read action of virtio-net config by not > handling reads to the start of the space as MSI related > operations. > > This fixes the MAC configuration of the device and makes uip network > work again. > > Signed-off-by: Sasha Levin Which commit broke it? > --- > tools/kvm/virtio/net.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c > index 35d4997..a74f1e7 100644 > --- a/tools/kvm/virtio/net.c > +++ b/tools/kvm/virtio/net.c > @@ -221,12 +221,6 @@ static bool virtio_net_pci_io_in(struct ioport *ioport, struct kvm *kvm, u16 por > kvm__irq_line(kvm, pci_header.irq_line, VIRTIO_IRQ_LOW); > ndev.isr = VIRTIO_IRQ_LOW; > break; > - case VIRTIO_MSI_CONFIG_VECTOR: > - ioport__write16(data, ndev.config_vector); > - break; > - case VIRTIO_MSI_QUEUE_VECTOR: > - ioport__write16(data, ndev.vq_vector[ndev.queue_selector]); > - break; > default: > ret = virtio_net_pci_io_device_specific_in(data, offset, size, count); > };