From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 2/2] kvm tools: Use correct offset for virtio-net config space Date: Fri, 12 Aug 2011 08:50:47 +0300 Message-ID: <1313128247.3651.0.camel@lappy> References: <1313095311-7413-1-git-send-email-levinsasha928@gmail.com> <1313095311-7413-2-git-send-email-levinsasha928@gmail.com> <1313126757.29737.25.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Pekka Enberg Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:50995 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189Ab1HLFvt (ORCPT ); Fri, 12 Aug 2011 01:51:49 -0400 Received: by wyg24 with SMTP id 24so1879741wyg.19 for ; Thu, 11 Aug 2011 22:51:48 -0700 (PDT) In-Reply-To: <1313126757.29737.25.camel@jaguar> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2011-08-12 at 08:25 +0300, Pekka Enberg wrote: > On Thu, 2011-08-11 at 23:41 +0300, Sasha Levin wrote: > > This patch fixes the read action of virtio-net config by not > > handling reads to the start of the space as MSI related > > operations. > > > > This fixes the MAC configuration of the device and makes uip network > > work again. > > > > Signed-off-by: Sasha Levin > > Which commit broke it? > The MSI-X one. I wasn't aware that pings always work in uip so I assumed it was working when I sent that patch. > > --- > > tools/kvm/virtio/net.c | 6 ------ > > 1 files changed, 0 insertions(+), 6 deletions(-) > > > > diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c > > index 35d4997..a74f1e7 100644 > > --- a/tools/kvm/virtio/net.c > > +++ b/tools/kvm/virtio/net.c > > @@ -221,12 +221,6 @@ static bool virtio_net_pci_io_in(struct ioport *ioport, struct kvm *kvm, u16 por > > kvm__irq_line(kvm, pci_header.irq_line, VIRTIO_IRQ_LOW); > > ndev.isr = VIRTIO_IRQ_LOW; > > break; > > - case VIRTIO_MSI_CONFIG_VECTOR: > > - ioport__write16(data, ndev.config_vector); > > - break; > > - case VIRTIO_MSI_QUEUE_VECTOR: > > - ioport__write16(data, ndev.vq_vector[ndev.queue_selector]); > > - break; > > default: > > ret = virtio_net_pci_io_device_specific_in(data, offset, size, count); > > }; > > -- Sasha.