From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] KVM: Implement support for the RH bit Date: Thu, 01 Sep 2011 23:24:37 +0300 Message-ID: <1314908677.3992.18.camel@lappy> References: <1314893135-3839-1-git-send-email-levinsasha928@gmail.com> <20110901174528.GA26451@redhat.com> <1314903592.3992.9.camel@lappy> <20110901193152.GB26451@redhat.com> <1314907111.3992.14.camel@lappy> <20110901200303.GC26451@redhat.com> <1314907500.3992.15.camel@lappy> <20110901201900.GD26451@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Avi Kivity , Marcelo Tosatti To: Gleb Natapov Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:45043 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703Ab1IAUYr (ORCPT ); Thu, 1 Sep 2011 16:24:47 -0400 Received: by wwf5 with SMTP id 5so2374411wwf.1 for ; Thu, 01 Sep 2011 13:24:46 -0700 (PDT) In-Reply-To: <20110901201900.GD26451@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-09-01 at 23:19 +0300, Gleb Natapov wrote: > On Thu, Sep 01, 2011 at 11:05:00PM +0300, Sasha Levin wrote: > > On Thu, 2011-09-01 at 23:03 +0300, Gleb Natapov wrote: > > > On Thu, Sep 01, 2011 at 10:58:31PM +0300, Sasha Levin wrote: > > > > By "actual addressing model" I meant checking the ICR of of each APIC to > > > > see if we should address it logically or physically. > > > > > > > This is definitely not what ICR of each APIC is about. > > > > Thats what I understood from section 10.6.2 in the spec. > > > Section 10.6.2 talks about ACPI messages generated by a CPU (IPIs) not > about addressing mode of the CPU itself (which is, again, per message). Right, but it was referred to by section 10.11.1, that's why I assumed so. Anyway, I'll just replace the patch with what you've initially suggested, so it would be contained within kvm_set_msi(). -- Sasha.