From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vadim Rozenfeld Subject: Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block. Date: Mon, 10 Oct 2011 11:40:52 +0200 Message-ID: <1318239652.2706.27.camel@vadimr.dell> References: <1318186375-27672-1-git-send-email-vrozenfe@redhat.com> <1318186375-27672-2-git-send-email-vrozenfe@redhat.com> <4E92968C.2000306@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Avi Kivity To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1028 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753097Ab1JJJk4 (ORCPT ); Mon, 10 Oct 2011 05:40:56 -0400 In-Reply-To: <4E92968C.2000306@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2011-10-10 at 08:54 +0200, Jan Kiszka wrote: > On 2011-10-09 20:52, Vadim Rozenfeld wrote: > > --- > > qemu-options.hx | 23 +++++++++++++++++++++++ > > vl.c | 2 ++ > > 2 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/qemu-options.hx b/qemu-options.hx > > index 3a13533..9f60059 100644 > > --- a/qemu-options.hx > > +++ b/qemu-options.hx > > @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG, QEMU_OPTION_kvm_shadow_memory, > > " allocate MEGABYTES for kvm mmu shadowing\n", > > QEMU_ARCH_I386) > > > > +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv, > > + "-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n" > > + " enable Hyper-V Enlightenment\n", > > + QEMU_ARCH_ALL) > > These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks > more appropriate than a new command line parameter. > I would like to keep hyper-v settings apart from cpu features for a very simple reason: if hyper-v VMBus support will be added one day, it won't be a CPU only feature anymore. > BTW, documentation and maybe also option processing should make clear > that this is limited to KVM mode for now. > Will add it. Vadim > Jan >