From: Sasha Levin <levinsasha928@gmail.com>
To: Osier Yang <jyang@redhat.com>
Cc: penberg@cs.helsinki.fi, kvm@vger.kernel.org, mingo@elte.hu,
asias.hejun@gmail.com, gorcunov@gmail.com
Subject: Re: [PATCH] kvm tools: Add method to stop ipc thread
Date: Tue, 25 Oct 2011 13:38:25 +0200 [thread overview]
Message-ID: <1319542705.3816.22.camel@lappy> (raw)
In-Reply-To: <4EA69891.6030002@redhat.com>
On Tue, 2011-10-25 at 19:08 +0800, Osier Yang wrote:
> 于 2011年10月25日 18:40, Sasha Levin 写道:
> > Stop the ipc thread when shutting down the hypervisor.
> >
> > This solves a bug where the .sock files weren't removed upon shutdown.
>
> I tested the patch, the socket is still there. (I'm testing with
> "--sdl", and
> shutdown the vm window). And the guest starting succeeded even if
> a socket with the name same as the specified guest name exists, which
> means I can start two guests with same socket, which is not right.
I've just tested it with --sdl, looks like closing the sdl window uses
the old method of IPC which I forgot to convert.
I'll fix that in a separate patch.
If you test it without --sdl it should work right.
--
Sasha.
prev parent reply other threads:[~2011-10-25 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 10:40 [PATCH] kvm tools: Add method to stop ipc thread Sasha Levin
2011-10-25 10:42 ` Pekka Enberg
2011-10-25 11:27 ` Sasha Levin
2011-10-25 11:08 ` Osier Yang
2011-10-25 11:38 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319542705.3816.22.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=jyang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox