From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] kvm tools: Add method to stop ipc thread Date: Tue, 25 Oct 2011 13:38:25 +0200 Message-ID: <1319542705.3816.22.camel@lappy> References: <1319539236-874-1-git-send-email-levinsasha928@gmail.com> <4EA69891.6030002@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Cc: penberg@cs.helsinki.fi, kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Osier Yang Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:44525 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755959Ab1JYLi3 (ORCPT ); Tue, 25 Oct 2011 07:38:29 -0400 Received: by faan17 with SMTP id n17so401187faa.19 for ; Tue, 25 Oct 2011 04:38:27 -0700 (PDT) In-Reply-To: <4EA69891.6030002@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2011-10-25 at 19:08 +0800, Osier Yang wrote: > 于 2011年10月25日 18:40, Sasha Levin 写道: > > Stop the ipc thread when shutting down the hypervisor. > > > > This solves a bug where the .sock files weren't removed upon shutdown. > > I tested the patch, the socket is still there. (I'm testing with > "--sdl", and > shutdown the vm window). And the guest starting succeeded even if > a socket with the name same as the specified guest name exists, which > means I can start two guests with same socket, which is not right. I've just tested it with --sdl, looks like closing the sdl window uses the old method of IPC which I forgot to convert. I'll fix that in a separate patch. If you test it without --sdl it should work right. -- Sasha.