From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
gorcunov@gmail.com, Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler
Date: Mon, 07 Nov 2011 17:38:18 +0200 [thread overview]
Message-ID: <1320680298.1428.89.camel@jaguar> (raw)
In-Reply-To: <1320679189-4123-1-git-send-email-levinsasha928@gmail.com>
On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote:
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
-ENOCHANGELOG :-)
I assume this is related to the git problems Darren Hart reported on
Google Plus?
> ---
> tools/kvm/virtio/9p.c | 25 +++++++++++++++++++++++++
> 1 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c
> index 1569bb2..08b1be7 100644
> --- a/tools/kvm/virtio/9p.c
> +++ b/tools/kvm/virtio/9p.c
> @@ -677,6 +677,30 @@ err_out:
> return;
> }
>
> +static void virtio_p9_remove(struct p9_dev *p9dev,
> + struct p9_pdu *pdu, u32 *outlen)
> +{
> + int ret;
> + u32 fid_val;
> + struct p9_fid *fid;
> + char full_path[PATH_MAX];
> +
> + virtio_p9_pdu_readf(pdu, "d", &fid_val);
> + fid = &p9dev->fids[fid_val];
> +
> + sprintf(full_path, "%s", fid->abs_path);
> + ret = remove(full_path);
> + if (ret < 0)
> + goto err_out;
> + *outlen = pdu->write_offset;
> + virtio_p9_set_reply_header(pdu, *outlen);
> + return;
> +
> +err_out:
> + virtio_p9_error_reply(p9dev, pdu, errno, outlen);
> + return;
> +}
> +
> static void virtio_p9_readlink(struct p9_dev *p9dev,
> struct p9_pdu *pdu, u32 *outlen)
> {
> @@ -1048,6 +1072,7 @@ static p9_handler *virtio_9p_dotl_handler [] = {
> [P9_TSYMLINK] = virtio_p9_symlink,
> [P9_TLCREATE] = virtio_p9_create,
> [P9_TWRITE] = virtio_p9_write,
> + [P9_TREMOVE] = virtio_p9_remove,
> };
>
> static struct p9_pdu *virtio_p9_pdu_init(struct kvm *kvm, struct virt_queue *vq)
next prev parent reply other threads:[~2011-11-07 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 15:19 [PATCH 1/2] kvm tools: Add missing 9p remove handler Sasha Levin
2011-11-07 15:19 ` [PATCH 2/2] kvm tools: Add missing 9p rename handler Sasha Levin
2011-11-07 15:38 ` Pekka Enberg [this message]
2011-11-07 15:38 ` [PATCH 1/2] kvm tools: Add missing 9p remove handler Sasha Levin
2011-11-07 15:43 ` Pekka Enberg
2011-11-07 15:45 ` Sasha Levin
2011-11-07 20:52 ` Darren Hart
2011-11-07 21:40 ` Sasha Levin
2011-11-07 22:16 ` Darren Hart
2011-11-08 6:36 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320680298.1428.89.camel@jaguar \
--to=penberg@cs.helsinki.fi \
--cc=asias.hejun@gmail.com \
--cc=dvhart@linux.intel.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox