From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [RFC] kvm tools: Add support for virtio-mmio Date: Tue, 15 Nov 2011 20:13:54 +0200 Message-ID: <1321380834.3200.10.camel@lappy> References: <1321375667-17284-1-git-send-email-levinsasha928@gmail.com> <1321379773.3200.9.camel@lappy> <4EC2ABEC.1040007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Peter Maydell , Pawel Moll , kvm@vger.kernel.org, asias.hejun@gmail.com, virtualization@lists.linux-foundation.org, penberg@kernel.org, gorcunov@gmail.com, mingo@elte.hu To: Avi Kivity Return-path: In-Reply-To: <4EC2ABEC.1040007@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: kvm.vger.kernel.org On Tue, 2011-11-15 at 20:14 +0200, Avi Kivity wrote: > On 11/15/2011 07:56 PM, Sasha Levin wrote: > > > > > > This isn't a PCI device, so does it make sense to use a PCI vendor > > > ID here? The kernel doesn't check the vendor ID at the moment, > > > but presumably the idea of the field is to allow the kernel to > > > work around implementation bugs/blacklist/whatever if necessary. > > > If that's the theory then it would make more sense for QEMU and > > > kvm-tool to use IDs that say "this is the QEMU implementation" > > > and "this is the kvm-tool implementation". > > > > > > (I picked 0x554D4551 for QEMU...) > > > > > > -- PMM > > > > I just sheepishly filled in the only vendor ID I knew of in the virtio > > spec :) > > > > Hmm... If thats the plan, it should probably be a virtio thing (not > > virtio-mmio specific). > > > > Either way, it could also use some clarification in the spec. > > The spec only covers virtio-pci; this virtio-mmio is completely > unspec'ed. IMO it's a timebomb waiting to explode. It is, look at Appendix X of the virtio-pci spec. -- Sasha.