public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Pawel Moll <pawel.moll@arm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"penberg@kernel.org" <penberg@kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"asias.hejun@gmail.com" <asias.hejun@gmail.com>,
	"gorcunov@gmail.com" <gorcunov@gmail.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>
Subject: Re: [RFC] kvm tools: Add support for virtio-mmio
Date: Wed, 16 Nov 2011 15:30:21 +0200	[thread overview]
Message-ID: <1321450221.3221.13.camel@lappy> (raw)
In-Reply-To: <1321449718.3137.258.camel@hornet.cambridge.arm.com>

On Wed, 2011-11-16 at 13:21 +0000, Pawel Moll wrote:
> On Tue, 2011-11-15 at 17:56 +0000, Sasha Levin wrote:
> > Hmm... If thats the plan, it should probably be a virtio thing (not
> > virtio-mmio specific).
> > 
> > Either way, it could also use some clarification in the spec.
> 
> Well, the spec (p. 2.1) says: "The Subsystem Vendor ID should reflect
> the PCI Vendor ID of the environment (it's currently only used for
> informational purposes by the guest).". The fact is that all the current
> virtio drivers simply ignore this field. So unless this changes I simply
> have no idea how to describe that register. "Put anything there, no one
> cares"? "Write zero now, may change in future"? Any ideas welcomed.
> 
> Cheers!
> 
> Paweł
> 
> PS. Thanks for defending my honour in the delayed-explosive-device
> thread ;-)

We can add an appendix to the virtio spec with known virtio subsystem
vendors, patch QEMU & KVM tool to pass that, and possibly modify the
QEMU related workarounds in the kernel to only do the workaround thing
if QEMU is set as the vendor.

-- 

Sasha.


      reply	other threads:[~2011-11-16 13:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 16:47 [RFC] kvm tools: Add support for virtio-mmio Sasha Levin
2011-11-15 17:00 ` Peter Maydell
2011-11-15 17:56   ` Sasha Levin
2011-11-15 18:14     ` Avi Kivity
2011-11-15 18:13       ` Sasha Levin
2011-11-15 18:18         ` Avi Kivity
2011-11-15 18:22           ` Sasha Levin
2011-11-16 13:21     ` Pawel Moll
2011-11-16 13:30       ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321450221.3221.13.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pawel.moll@arm.com \
    --cc=penberg@kernel.org \
    --cc=peter.maydell@linaro.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox