From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] kvm tools: Process virito blk requests in separate thread Date: Thu, 01 Dec 2011 10:58:37 +0200 Message-ID: <1322729917.3702.10.camel@lappy> References: <1322576888-7451-1-git-send-email-asias.hejun@gmail.com> <1322577409.7003.7.camel@lappy> <4ED5D996.1070408@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Asias He , Cyrill Gorcunov , Ingo Molnar , kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:55585 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110Ab1LAI6u (ORCPT ); Thu, 1 Dec 2011 03:58:50 -0500 Received: by eeaq14 with SMTP id q14so315469eea.19 for ; Thu, 01 Dec 2011 00:58:48 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-12-01 at 10:48 +0200, Pekka Enberg wrote: > On Wed, 30 Nov 2011, Asias He wrote: > >>> In virtio net's notify_vq(), we simply signal the tx/rx handle thread > >>> and return. > >> > >> Why not use the threadpool? > > > > No. > > Sasha? I was looking into the concept of adding 'dedicated' threads to the threadpool, since when the threadpool was added originally one of the purposes was to have all worker threads in a single place. This way we could still have threads in one place, which would make it easier to control all of them but still won't hurt performance of those threads. We can merge this patch, and I'll do the dedicated thread patch on top of it. -- Sasha.