From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH] KVM: Veirfy memory slot only for readability Date: Thu, 1 Dec 2011 21:42:56 +0200 Message-ID: <1322768576-9242-1-git-send-email-levinsasha928@gmail.com> Cc: Sasha Levin , Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org To: linux-kernel@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org It's enough for memory slot to be readable, as the comment above the check states. A user should be able to create read-only memory slot. Cc: Avi Kivity Cc: Marcelo Tosatti Cc: kvm@vger.kernel.org Signed-off-by: Sasha Levin --- virt/kvm/kvm_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index e289486..b92883f 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -727,7 +727,7 @@ int __kvm_set_memory_region(struct kvm *kvm, /* We can read the guest memory with __xxx_user() later on. */ if (user_alloc && ((mem->userspace_addr & (PAGE_SIZE - 1)) || - !access_ok(VERIFY_WRITE, + !access_ok(VERIFY_READ, (void __user *)(unsigned long)mem->userspace_addr, mem->memory_size))) goto out; -- 1.7.8.rc4