From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 08/28] kvm tools: Fix KVM_RUN exit code check Date: Tue, 06 Dec 2011 10:22:48 +0200 Message-ID: <1323159768.3882.9.camel@lappy> References: <4EDD8E82.1010909@ozlabs.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Matt Evans Return-path: In-Reply-To: <4EDD8E82.1010909@ozlabs.org> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org If KVM_RUN can actually return anything besides 0 or -1 it may be also worthwhile to update Documentation/virtual/kvm/api.txt . What are the cases where it happens? On Tue, 2011-12-06 at 14:39 +1100, Matt Evans wrote: > kvm_cpu__run() currently die()s if KVM_RUN returns non-zero. Some architectures > may return positive values in non-error cases, whereas real errors are always > negative return values. Check for those instead. > > Signed-off-by: Matt Evans > --- > tools/kvm/kvm-cpu.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/kvm/kvm-cpu.c b/tools/kvm/kvm-cpu.c > index 9bc0796..884a89f 100644 > --- a/tools/kvm/kvm-cpu.c > +++ b/tools/kvm/kvm-cpu.c > @@ -30,7 +30,7 @@ void kvm_cpu__run(struct kvm_cpu *vcpu) > int err; > > err = ioctl(vcpu->vcpu_fd, KVM_RUN, 0); > - if (err && (errno != EINTR && errno != EAGAIN)) > + if (err < 0 && (errno != EINTR && errno != EAGAIN)) > die_perror("KVM_RUN failed"); > } > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sasha.