From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] kvm tools: Ninja out support for VIRTIO_F_FEATURES_HIGH Date: Tue, 06 Dec 2011 11:57:20 +0200 Message-ID: <1323165440.3882.25.camel@lappy> References: <1323161121-5660-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com, kvm@vger.kernel.org, Rusty Russell To: Pekka Enberg Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:42981 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933018Ab1LFJ5k (ORCPT ); Tue, 6 Dec 2011 04:57:40 -0500 Received: by eaak14 with SMTP id k14so4904532eaa.19 for ; Tue, 06 Dec 2011 01:57:38 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2011-12-06 at 11:47 +0200, Pekka Enberg wrote: > On Tue, Dec 6, 2011 at 10:45 AM, Sasha Levin wrote: > > Rusty has just removed it out of the spec. Since we probably the only ones > > who implemented support for it, we should remove it out of our code as well. > > > > There is no issue with breaking anything since nothing else worked with it, > > so it's fully backwards compatible. > > > > Cc: Rusty Russell > > Signed-off-by: Sasha Levin > > Applied, thanks! > > How is this going to work going forward? Should I ask Rusty for an ACK > before merging code that implements some (new) part of the virtio > spec? I like the fact that we're bleeding edge but it's pointless for > everyone involved if we implement something that's known to be > half-baked in the spec. There was a little cheating involved here since the spec basically broke backwards compatibility by removing 64 bit features, so it's a special case and probably won't happen (too many times) again. Half baked features usually don't go into the spec as well, Rusty usually insists on having a working code besides just spec updates, so again - this was one of those rare special cases. If Rusty or Michael could ACK our virtio patches it would be awesome. -- Sasha.