From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 24/28] kvm tools: Fix virtio-pci endian bug when reading
 VIRTIO_PCI_QUEUE_NUM
Date: Tue, 06 Dec 2011 15:15:56 +0200
Message-ID: <1323177356.8489.1.camel@lappy>
References: <cover.1323141075.git.matt@ozlabs.org>
	 <4EDD8F25.7080106@ozlabs.org>
	 <CAOJsxLGXbBdHUq6U7jjP6iceAiLJS+n+hLcA=87Ro5Sen-ZzdA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Matt Evans <matt@ozlabs.org>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, Asias He <asias.hejun@gmail.com>,
	Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <CAOJsxLGXbBdHUq6U7jjP6iceAiLJS+n+hLcA=87Ro5Sen-ZzdA@mail.gmail.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, 2011-12-06 at 12:26 +0200, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans <matt@ozlabs.org> wrote:
> > The field size is currently wrong, read into a 32bit word instead of 16.  This
> > casues trouble when BE.
> >
> > Signed-off-by: Matt Evans <matt@ozlabs.org>
> > ---
> >  tools/kvm/virtio/pci.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c
> > index 0ae93fb..6b27ff8 100644
> > --- a/tools/kvm/virtio/pci.c
> > +++ b/tools/kvm/virtio/pci.c
> > @@ -116,8 +116,7 @@ static bool virtio_pci__io_in(struct ioport *ioport, struct kvm *kvm, u16 port,
> >                break;
> >        case VIRTIO_PCI_QUEUE_NUM:
> >                val = vtrans->virtio_ops->get_size_vq(kvm, vpci->dev, vpci->queue_selector);
> > -               ioport__write32(data, val);
> > -               break;
> > +               ioport__write16(data, val);
> >                break;
> >        case VIRTIO_PCI_STATUS:
> >                ioport__write8(data, vpci->status);
> 
> Looks good to me. Asias, Sasha?

Looks good.

-- 

Sasha.