kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: linux-kernel@vger.kernel.org, Joerg Roedel <joerg.roedel@amd.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: VMX: Notify if VMX is already in use
Date: Wed, 07 Dec 2011 16:24:51 +0200	[thread overview]
Message-ID: <1323267891.4009.16.camel@lappy> (raw)
In-Reply-To: <4EDF76D6.7020800@redhat.com>

On Wed, 2011-12-07 at 16:23 +0200, Avi Kivity wrote:
> On 12/07/2011 04:18 PM, Sasha Levin wrote:
> > On Wed, 2011-12-07 at 16:17 +0200, Avi Kivity wrote:
> > > On 12/01/2011 08:30 PM, Sasha Levin wrote:
> > > > Currently we silently fail if VMX is already in use by a different
> > > > virtualization technology.
> > > >
> > > > This is bad since it's non-obvious for the user, and its not too uncommon
> > > > for users to have several of these installed on same host.
> > > >
> > > > This patch adds a message to notify the user of the problem.
> > > >
> > > 
> > > Does this actually happen?  With which hypervisor?
> >
> > vbox
> >
> > It turns VMX/SVM on when it loads, regardless of whether it's running a
> > guest or not.
> 
> That's odd.  IIRC when we discussed this with them, they were executing
> VMXON/VMXOFF dynamically.  Looks like they changed this.
> 
> Anyway, please adjust according to Joerg's comment (and add the word
> "using"), and I'll apply.

I've seen it the day before I've sent those patches. vbox driver loaded,
kvm silently failed and rdmsr showed SVME turned on.

Will resend.

-- 

Sasha.

  reply	other threads:[~2011-12-07 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 18:30 [PATCH 1/2] KVM: VMX: Notify if VMX is already in use Sasha Levin
2011-12-01 18:30 ` [PATCH 2/2] KVM: SVM: Notify if SVM " Sasha Levin
2011-12-02  8:53   ` Joerg Roedel
2011-12-07 14:17 ` [PATCH 1/2] KVM: VMX: Notify if VMX " Avi Kivity
2011-12-07 14:18   ` Sasha Levin
2011-12-07 14:23     ` Avi Kivity
2011-12-07 14:24       ` Sasha Levin [this message]
2011-12-07 14:26         ` Avi Kivity
2011-12-07 14:42           ` Sasha Levin
2011-12-07 15:15           ` Sasha Levin
2011-12-07 15:31             ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323267891.4009.16.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=avi@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).