From: Sasha Levin <levinsasha928@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: linux-kernel@vger.kernel.org, Joerg Roedel <joerg.roedel@amd.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: VMX: Notify if VMX is already in use
Date: Wed, 07 Dec 2011 16:42:10 +0200 [thread overview]
Message-ID: <1323268930.4009.19.camel@lappy> (raw)
In-Reply-To: <4EDF7797.9080103@redhat.com>
On Wed, 2011-12-07 at 16:26 +0200, Avi Kivity wrote:
> On 12/07/2011 04:24 PM, Sasha Levin wrote:
> > >
> > > That's odd. IIRC when we discussed this with them, they were executing
> > > VMXON/VMXOFF dynamically. Looks like they changed this.
> > >
> > > Anyway, please adjust according to Joerg's comment (and add the word
> > > "using"), and I'll apply.
> >
> > I've seen it the day before I've sent those patches. vbox driver loaded,
> > kvm silently failed and rdmsr showed SVME turned on.
> >
> > Will resend.
>
> Ah, maybe they do it differently on AMD. Or they changed things.
>
> btw, was it really silent? Didn't modprobe complain?
>
> The patch makes sense in any case.
Not totally silent, there was an error about KVM failing to enable
hardware virtualization, but it was generic and didn't really point to
the problem.
--
Sasha.
next prev parent reply other threads:[~2011-12-07 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 18:30 [PATCH 1/2] KVM: VMX: Notify if VMX is already in use Sasha Levin
2011-12-01 18:30 ` [PATCH 2/2] KVM: SVM: Notify if SVM " Sasha Levin
2011-12-02 8:53 ` Joerg Roedel
2011-12-07 14:17 ` [PATCH 1/2] KVM: VMX: Notify if VMX " Avi Kivity
2011-12-07 14:18 ` Sasha Levin
2011-12-07 14:23 ` Avi Kivity
2011-12-07 14:24 ` Sasha Levin
2011-12-07 14:26 ` Avi Kivity
2011-12-07 14:42 ` Sasha Levin [this message]
2011-12-07 15:15 ` Sasha Levin
2011-12-07 15:31 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323268930.4009.19.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).