kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	gorcunov@gmail.com, asias.hejun@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Add 'kvm nmi' command
Date: Wed, 07 Dec 2011 19:31:21 +0200	[thread overview]
Message-ID: <1323279081.3904.2.camel@lappy> (raw)
In-Reply-To: <1323278034.1428.168.camel@jaguar>

On Wed, 2011-12-07 at 19:13 +0200, Pekka Enberg wrote:
> On Wed, 2011-12-07 at 09:16 +0100, Ingo Molnar wrote:
> > * Sasha Levin <levinsasha928@gmail.com> wrote:
> > 
> > > This patch adds a 'kvm nmi' command which can be used to trigger NMIs in
> > > guests.
> > > 
> > > Mostly useful for debugging purposes.
> > 
> > Could we make this something like 'kvm debug nmi'?
> > 
> > We already have some debug functionality, right? Those should be 
> > consolidated under 'kvm debug'.
> 
> Agreed. It's probably best to implement this as a option to 'kvm debug'.
> For example,
> 
>   kvm debug [-n|--nmi]
> 
> or something.

Okay, so changes required so far:

1. 'kvm nmi' -> 'kvm debug --nmi'
2. Use method described in api.txt
3. Use same thread as vcpu.

Will modify and resend.

-- 

Sasha.


  reply	other threads:[~2011-12-07 17:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 20:42 [PATCH] kvm tools: Add 'kvm nmi' command Sasha Levin
2011-12-07  8:16 ` Ingo Molnar
2011-12-07 17:13   ` Pekka Enberg
2011-12-07 17:31     ` Sasha Levin [this message]
2011-12-07 10:21 ` Gleb Natapov
2011-12-07 10:31   ` Cyrill Gorcunov
2011-12-07 10:33     ` Gleb Natapov
2011-12-07 10:37       ` Cyrill Gorcunov
2011-12-07 10:41         ` Gleb Natapov
2011-12-07 10:49           ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323279081.3904.2.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).