From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] kvm tools: Add 'kvm nmi' command
Date: Wed, 07 Dec 2011 19:31:21 +0200
Message-ID: <1323279081.3904.2.camel@lappy>
References: <1323204175-17234-1-git-send-email-levinsasha928@gmail.com>
	 <20111207081654.GB8023@elte.hu> <1323278034.1428.168.camel@jaguar>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Ingo Molnar <mingo@elte.hu>, gorcunov@gmail.com,
	asias.hejun@gmail.com, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:41422 "EHLO
	mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756756Ab1LGRbp (ORCPT
	<rfc822;kvm@vger.kernel.org>); Wed, 7 Dec 2011 12:31:45 -0500
Received: by lagp5 with SMTP id p5so330904lag.19
        for <kvm@vger.kernel.org>; Wed, 07 Dec 2011 09:31:44 -0800 (PST)
In-Reply-To: <1323278034.1428.168.camel@jaguar>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2011-12-07 at 19:13 +0200, Pekka Enberg wrote:
> On Wed, 2011-12-07 at 09:16 +0100, Ingo Molnar wrote:
> > * Sasha Levin <levinsasha928@gmail.com> wrote:
> > 
> > > This patch adds a 'kvm nmi' command which can be used to trigger NMIs in
> > > guests.
> > > 
> > > Mostly useful for debugging purposes.
> > 
> > Could we make this something like 'kvm debug nmi'?
> > 
> > We already have some debug functionality, right? Those should be 
> > consolidated under 'kvm debug'.
> 
> Agreed. It's probably best to implement this as a option to 'kvm debug'.
> For example,
> 
>   kvm debug [-n|--nmi]
> 
> or something.

Okay, so changes required so far:

1. 'kvm nmi' -> 'kvm debug --nmi'
2. Use method described in api.txt
3. Use same thread as vcpu.

Will modify and resend.

-- 

Sasha.