From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH] kvm tools: Clean up LINT assignment code Date: Sun, 11 Dec 2011 21:50:19 +0200 Message-ID: <1323633019-8424-1-git-send-email-levinsasha928@gmail.com> Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com, kvm@vger.kernel.org, Sasha Levin To: penberg@kernel.org Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:58566 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265Ab1LKTuz (ORCPT ); Sun, 11 Dec 2011 14:50:55 -0500 Received: by eaaj10 with SMTP id j10so258724eaa.19 for ; Sun, 11 Dec 2011 11:50:54 -0800 (PST) Sender: kvm-owner@vger.kernel.org List-ID: Just set delivery mode directly without going through ugly casting. This cleans up and simplifies the code. Signed-off-by: Sasha Levin --- tools/kvm/x86/kvm-cpu.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/kvm/x86/kvm-cpu.c b/tools/kvm/x86/kvm-cpu.c index 27b7a8f..cc1f560 100644 --- a/tools/kvm/x86/kvm-cpu.c +++ b/tools/kvm/x86/kvm-cpu.c @@ -81,18 +81,12 @@ static int kvm_cpu__set_lint(struct kvm_cpu *vcpu) { struct kvm_lapic_state klapic; struct local_apic *lapic = (void *)&klapic; - u32 lvt; if (ioctl(vcpu->vcpu_fd, KVM_GET_LAPIC, &klapic)) return -1; - lvt = *(u32 *)&lapic->lvt_lint0; - lvt = SET_APIC_DELIVERY_MODE(lvt, APIC_MODE_EXTINT); - *(u32 *)&lapic->lvt_lint0 = lvt; - - lvt = *(u32 *)&lapic->lvt_lint1; - lvt = SET_APIC_DELIVERY_MODE(lvt, APIC_MODE_NMI); - *(u32 *)&lapic->lvt_lint1 = lvt; + lapic->lvt_lint0.delivery_mode = APIC_MODE_EXTINT; + lapic->lvt_lint1.delivery_mode = APIC_MODE_NMI; return ioctl(vcpu->vcpu_fd, KVM_SET_LAPIC, &klapic); } -- 1.7.8