public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com,
	kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm tools: Add ability to assert/deassert IRQs using 'kvm debug'
Date: Tue, 13 Dec 2011 07:37:29 +0200	[thread overview]
Message-ID: <1323754649.3269.13.camel@lappy> (raw)
In-Reply-To: <1323725635.1428.300.camel@jaguar>

On Mon, 2011-12-12 at 23:33 +0200, Pekka Enberg wrote:
> On Mon, 2011-12-12 at 11:19 +0200, Sasha Levin wrote:
> > Add options to assert and deassert IRQs using 'kvm debug'. For example, to
> > assert IRQ4 in guest 'my_instance':
> > 
> > 	vm debug -n my_instance --assert_irq 4
> > 
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> 
> Why is this useful? How does it protect against random users asserting
> IRQs in the guest?

Mostly useful to debug hangs as it lets the user trigger an irq which
wasn't triggered the way it was supposed to be triggered.

We discussed doing this feature in when we were working on the virtio
code and had random hangs which we believed were caused by our code not
asserting IRQs the way it should be doing. This way we can do it
manually to debug such issues.

It doesn't prevent a user to shoot himself in the leg.

-- 

Sasha.


      reply	other threads:[~2011-12-13  5:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  9:19 [PATCH 1/2] kvm tools: Clean up 'kvm debug' Sasha Levin
2011-12-12  9:19 ` [PATCH 2/2] kvm tools: Add ability to assert/deassert IRQs using " Sasha Levin
2011-12-12 21:33   ` Pekka Enberg
2011-12-13  5:37     ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323754649.3269.13.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox