From: Sasha Levin <levinsasha928@gmail.com>
To: zanghongyong@huawei.com
Cc: kvm@vger.kernel.org, penberg@kernel.org, xiaowei.yang@huawei.com,
hanweidong@huawei.com, wusongwei@huawei.com, kongbo@huawei.com
Subject: Re: [PATCH] kvm tools: Make the whole guest memory mergeable
Date: Fri, 16 Dec 2011 07:50:21 +0200 [thread overview]
Message-ID: <1324014621.4496.3.camel@lappy> (raw)
In-Reply-To: <1323997263-2031-1-git-send-email-zanghongyong@huawei.com>
On Fri, 2011-12-16 at 09:01 +0800, zanghongyong@huawei.com wrote:
> If a guest's ram_size exceeds KVM_32BIT_GAP_START, the corresponding kvm tool's
> virtual address size should be (ram_size + KVM_32BIT_GAP_SIZE), rather than ram_size.
You're right.
There are more places than just the madvise() code which make the same
error you've spotted (for example, the memslot allocation code), so
instead of trying to fix all of them I'd suggest to just update ram_size
in kvm__arch_init() before allocating everything - that should fix all
of them at once.
--
Sasha.
next prev parent reply other threads:[~2011-12-16 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 1:01 [PATCH] kvm tools: Make the whole guest memory mergeable zanghongyong
2011-12-16 5:50 ` Sasha Levin [this message]
2011-12-16 7:02 ` Zang Hongyong
2011-12-16 7:23 ` Sasha Levin
2011-12-16 8:36 ` Zang Hongyong
2011-12-16 8:45 ` Sasha Levin
2011-12-16 9:33 ` Zang Hongyong
2011-12-16 9:46 ` Sasha Levin
2011-12-19 2:39 ` Zang Hongyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324014621.4496.3.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=hanweidong@huawei.com \
--cc=kongbo@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=wusongwei@huawei.com \
--cc=xiaowei.yang@huawei.com \
--cc=zanghongyong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).