From: Avi Kivity <avi@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Cc: xen-devel@lists.xensource.com, kvm@vger.kernel.org
Subject: [PATCH 21/23] virtio-balloon: avoid cpu_get_physical_page_desc()
Date: Mon, 19 Dec 2011 16:13:42 +0200 [thread overview]
Message-ID: <1324304024-11220-22-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1324304024-11220-1-git-send-email-avi@redhat.com>
This reaches into the innards of the memory core, which are being
changed. Switch to a memory API version.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/virtio-balloon.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index e24a2bf..bb4a8dd 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -21,6 +21,7 @@
#include "balloon.h"
#include "virtio-balloon.h"
#include "kvm.h"
+#include "exec-memory.h"
#if defined(__linux__)
#include <sys/mman.h>
@@ -70,6 +71,7 @@ static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq)
{
VirtIOBalloon *s = to_virtio_balloon(vdev);
VirtQueueElement elem;
+ MemoryRegionSection section;
while (virtqueue_pop(vq, &elem)) {
size_t offset = 0;
@@ -82,13 +84,17 @@ static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq)
pa = (ram_addr_t)ldl_p(&pfn) << VIRTIO_BALLOON_PFN_SHIFT;
offset += 4;
- addr = cpu_get_physical_page_desc(pa);
- if ((addr & ~TARGET_PAGE_MASK) != IO_MEM_RAM)
+ /* FIXME: remove get_system_memory(), but how? */
+ section = memory_region_find(get_system_memory(), pa, 1);
+ if (!section.mr || !memory_region_is_ram(section.mr))
continue;
- /* Using qemu_get_ram_ptr is bending the rules a bit, but
+ /* Using memory_region_get_ram_ptr is bending the rules a bit, but
should be OK because we only want a single page. */
- balloon_page(qemu_get_ram_ptr(addr), !!(vq == s->dvq));
+ addr -= section.offset_within_address_space;
+ addr += section.offset_within_region;
+ balloon_page(memory_region_get_ram_ptr(section.mr) + addr,
+ !!(vq == s->dvq));
}
virtqueue_push(vq, &elem, offset);
--
1.7.7.1
next prev parent reply other threads:[~2011-12-19 14:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 14:13 [PATCH 00/23] Remove cpu_get_physical_page_desc() Avi Kivity
2011-12-19 14:13 ` [PATCH 01/23] memory: introduce memory_region_find() Avi Kivity
2011-12-19 14:50 ` [Qemu-devel] " Anthony Liguori
2011-12-19 15:04 ` Avi Kivity
2011-12-19 15:10 ` Anthony Liguori
2011-12-19 15:17 ` Avi Kivity
2011-12-19 15:25 ` Anthony Liguori
2011-12-19 15:28 ` Avi Kivity
2011-12-19 15:52 ` Avi Kivity
2011-12-19 14:13 ` [PATCH 02/23] sysbus: add sysbus_address_space() Avi Kivity
2011-12-19 14:13 ` [PATCH 03/23] memory: add memory_region_is_ram() Avi Kivity
2011-12-19 14:13 ` [PATCH 04/23] framebuffer: drop use of cpu_get_physical_page_desc() Avi Kivity
2011-12-19 14:13 ` [PATCH 05/23] memory: add memory_region_is_rom() Avi Kivity
2011-12-19 14:13 ` [PATCH 06/23] loader: remove calls to cpu_get_physical_page_desc() Avi Kivity
2011-12-19 14:13 ` [PATCH 07/23] framebuffer: drop use of cpu_physical_sync_dirty_bitmap() Avi Kivity
2011-12-19 14:13 ` [PATCH 08/23] memory: replace cpu_physical_sync_dirty_bitmap() with a memory API Avi Kivity
2011-12-19 14:13 ` [PATCH 09/23] memory: add API for observing updates to the physical memory map Avi Kivity
2011-12-19 14:13 ` [PATCH 10/23] memory: add memory_region_is_logging() Avi Kivity
2011-12-19 14:13 ` [PATCH 11/23] kvm: switch kvm slots to use host virtual address instead of ram_addr_t Avi Kivity
2011-12-19 14:13 ` [PATCH 12/23] fixup: listener fixes Avi Kivity
2011-12-19 14:32 ` [Qemu-devel] " Peter Maydell
2011-12-19 14:48 ` Avi Kivity
2011-12-19 14:13 ` [PATCH 13/23] kvm: convert to MemoryListener API Avi Kivity
2012-01-15 10:49 ` Jan Kiszka
2012-01-15 10:52 ` Jan Kiszka
2012-01-15 12:35 ` Avi Kivity
2012-01-15 12:40 ` Jan Kiszka
2012-01-15 12:49 ` Avi Kivity
2012-01-15 12:50 ` Avi Kivity
2012-01-15 12:53 ` Jan Kiszka
2011-12-19 14:13 ` [PATCH 14/23] vhost: " Avi Kivity
2011-12-22 12:50 ` Michael S. Tsirkin
2011-12-22 12:50 ` Avi Kivity
2011-12-22 12:57 ` Michael S. Tsirkin
2011-12-22 12:57 ` Avi Kivity
2011-12-19 14:13 ` [PATCH 15/23] xen, vga: add API for registering the framebuffer Avi Kivity
2011-12-19 14:13 ` [PATCH 16/23] memory: temporarily add memory_region_get_ram_addr() Avi Kivity
2011-12-19 14:13 ` [PATCH 17/23] xen: convert to MemoryListener API Avi Kivity
2012-01-04 18:06 ` Stefano Stabellini
2012-01-04 19:42 ` Avi Kivity
2011-12-19 14:13 ` [PATCH 18/23] memory: remove CPUPhysMemoryClient Avi Kivity
2011-12-19 14:13 ` [PATCH 19/23] kvm: avoid cpu_get_physical_page_desc() Avi Kivity
2011-12-19 14:13 ` [PATCH 20/23] vhost: " Avi Kivity
2011-12-22 12:48 ` Michael S. Tsirkin
2011-12-22 12:49 ` Avi Kivity
2011-12-19 14:13 ` Avi Kivity [this message]
2011-12-19 14:13 ` [PATCH 22/23] sparc: " Avi Kivity
2011-12-19 14:13 ` [PATCH 23/23] Remove cpu_get_physical_page_desc() Avi Kivity
2011-12-19 14:54 ` [Qemu-devel] [PATCH 00/23] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324304024-11220-22-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).