From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [RFC 01/12] kvm tools: Split kvm_cmd_run into init, work and
 uninit
Date: Tue, 20 Dec 2011 12:09:26 +0200
Message-ID: <1324375766.22797.0.camel@lappy>
References: <1324303114-5948-1-git-send-email-levinsasha928@gmail.com>
	 <1324303114-5948-2-git-send-email-levinsasha928@gmail.com>
	 <1324329976.1428.316.camel@jaguar>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com,
	kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:48131 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751387Ab1LTIKF (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 20 Dec 2011 03:10:05 -0500
Received: by wgbdr13 with SMTP id dr13so12057741wgb.1
        for <kvm@vger.kernel.org>; Tue, 20 Dec 2011 00:10:04 -0800 (PST)
In-Reply-To: <1324329976.1428.316.camel@jaguar>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2011-12-19 at 23:26 +0200, Pekka Enberg wrote:
> On Mon, 2011-12-19 at 15:58 +0200, Sasha Levin wrote:
> > +int kvm_cmd_run(int argc, const char **argv, const char *prefix)
> > +{
> > +	int r, ret;
> > +
> > +	r = kvm_cmd_run_init(argc, argv);
> > +	ret = kvm_cmd_run_work();
> > +	r = kvm_cmd_run_uninit(ret);
> > +
> > +	return ret;
> >  }
> 
> What's going on here? Why do you bother saving 'r' if you don't use it
> for anything?

It was part of my plans to get kvm_cmd_run_{init, uninit} as a simple
for(;;) through a init/uninit function pointer array, right now it's
simply meaningless there.

-- 

Sasha.