kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Asias He <asias.hejun@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	kvm@vger.kernel.org, Asias He <asias.hejun@gmail.com>
Subject: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
Date: Wed, 21 Dec 2011 16:07:22 +0800	[thread overview]
Message-ID: <1324454842-28139-2-git-send-email-asias.hejun@gmail.com> (raw)
In-Reply-To: <1324454842-28139-1-git-send-email-asias.hejun@gmail.com>

./lkvm {pause,resume} do not give any feedback to user who uses these
commands in the console where the command run.

This patch makes the command output in the command console instead of
guest console.

Signed-off-by: Asias He <asias.hejun@gmail.com>
---
 tools/kvm/builtin-pause.c  |    2 ++
 tools/kvm/builtin-resume.c |    2 ++
 tools/kvm/builtin-run.c    |    1 -
 3 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
index 107641c..a8e805e 100644
--- a/tools/kvm/builtin-pause.c
+++ b/tools/kvm/builtin-pause.c
@@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
 	if (r < 0)
 		return r;
 
+	printf("Guest %s paused\n", name);
+
 	return 0;
 }
 
diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
index 7b87f59..fd00763 100644
--- a/tools/kvm/builtin-resume.c
+++ b/tools/kvm/builtin-resume.c
@@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
 	if (r < 0)
 		return r;
 
+	printf("Guest %s resumed\n", name);
+
 	return 0;
 }
 
diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
index fac274c..8f512c3 100644
--- a/tools/kvm/builtin-run.c
+++ b/tools/kvm/builtin-run.c
@@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
 		return;
 
 	is_paused = !is_paused;
-	pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
 }
 
 static void handle_debug(int fd, u32 type, u32 len, u8 *msg)
-- 
1.7.7.3


  reply	other threads:[~2011-12-21  8:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21  8:07 [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Asias He
2011-12-21  8:07 ` Asias He [this message]
2011-12-21  9:14   ` [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output Wanlong Gao
2011-12-22  2:15     ` Asias He
2011-12-22  6:52       ` Pekka Enberg
2011-12-21  9:14 ` [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Wanlong Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324454842-28139-2-git-send-email-asias.hejun@gmail.com \
    --to=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).