From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] kvm tools: ignore nonexisting custom stage2 Date: Wed, 21 Dec 2011 12:18:32 +0200 Message-ID: <1324462712.3914.2.camel@lappy> References: <20111221091509.19899.90043.stgit@zurg> <1324460817.4579.11.camel@lappy> <4EF1ABA5.4050402@openvz.org> <1324462260.3914.0.camel@lappy> <4EF1B1AB.7060102@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "penberg@kernel.org" , "kvm@vger.kernel.org" To: Konstantin Khlebnikov Return-path: Received: from mail-qw0-f53.google.com ([209.85.216.53]:64535 "EHLO mail-qw0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752924Ab1LUKSg (ORCPT ); Wed, 21 Dec 2011 05:18:36 -0500 Received: by qadb15 with SMTP id b15so4605246qad.19 for ; Wed, 21 Dec 2011 02:18:36 -0800 (PST) In-Reply-To: <4EF1B1AB.7060102@openvz.org> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2011-12-21 at 14:15 +0400, Konstantin Khlebnikov wrote: > Sasha Levin wrote: > > On Wed, 2011-12-21 at 13:49 +0400, Konstantin Khlebnikov wrote: > >> Sasha Levin wrote: > >>> On Wed, 2011-12-21 at 13:15 +0300, Konstantin Khlebnikov wrote: > >>>> fix permanent failing with message "Fatal: Failed linking stage 2 of init." > >>>> if there is no custom init_stage2. > >>> > >>> Why would it happen? whats the usecase? > >>> > >> > >> run "lkvm run" in dir there is no "guest" subdirectory > > > > Yup, but how would that happen? 'guest' is part of the git tree and the > > makefile builds the executables in it. > > > > Current wokring directory can be anything, > or lkvm supposed to work only if cwd is .../linux-kvm/tools/kvm ? =) Right, so this is the issue that should really be fixed. If you omit the 'guest' directory, custom rootfs won't work at all either, so just ignoring that check would lead to breakage later on. -- Sasha.