From: Asias He <asias.hejun@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
kvm@vger.kernel.org, Asias He <asias.hejun@gmail.com>
Subject: [PATCH 6/6] kvm tools: Use kvm_ipc__send to send IPC msg
Date: Thu, 22 Dec 2011 10:10:47 +0800 [thread overview]
Message-ID: <1324519847-19897-6-git-send-email-asias.hejun@gmail.com> (raw)
In-Reply-To: <1324519847-19897-1-git-send-email-asias.hejun@gmail.com>
No need to send IPC msg using bare write() any more.
Signed-off-by: Asias He <asias.hejun@gmail.com>
---
tools/kvm/builtin-list.c | 20 ++++----------------
1 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/tools/kvm/builtin-list.c b/tools/kvm/builtin-list.c
index e74b636..eb0ac6c 100644
--- a/tools/kvm/builtin-list.c
+++ b/tools/kvm/builtin-list.c
@@ -11,16 +11,6 @@
#include <signal.h>
#include <fcntl.h>
-struct pid_cmd {
- u32 type;
- u32 len;
-};
-
-struct vmstate_cmd {
- u32 type;
- u32 len;
-};
-
static bool run;
static bool rootfs;
@@ -47,11 +37,10 @@ void kvm_list_help(void)
static pid_t get_pid(int sock)
{
- struct pid_cmd cmd = {KVM_IPC_PID, 0};
- int r;
pid_t pid;
+ int r;
- r = write(sock, &cmd, sizeof(cmd));
+ r = kvm_ipc__send(sock, KVM_IPC_PID);
if (r < 0)
return r;
@@ -64,11 +53,10 @@ static pid_t get_pid(int sock)
static int get_vmstate(int sock)
{
- struct vmstate_cmd cmd = {KVM_IPC_VMSTATE, 0};
- int r;
int vmstate;
+ int r;
- r = write(sock, &cmd, sizeof(cmd));
+ r = kvm_ipc__send(sock, KVM_IPC_VMSTATE);
if (r < 0)
return r;
--
1.7.7.3
prev parent reply other threads:[~2011-12-22 2:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 2:10 [PATCH 1/6] kvm tools: Handle multiple IPC cmd at a time Asias He
2011-12-22 2:10 ` [PATCH 2/6] kvm tools: Introduce KVM_IPC_VMSTATE IPC cmd Asias He
2011-12-22 2:10 ` [PATCH 3/6] kvm tools: Respect paused status in ./lkvm list Asias He
2011-12-22 2:10 ` [PATCH 4/6] kvm tools: Improve 'lkvm {pause,resume}'s output Asias He
2011-12-22 2:10 ` [PATCH 5/6] kvm tools: Remove resume pause noise Asias He
2011-12-22 2:10 ` Asias He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324519847-19897-6-git-send-email-asias.hejun@gmail.com \
--to=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).