From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julian Stecklina <js@alien8.de>
Subject: Re: [PATCH] KVM: Don't mistreat edge-triggered INIT IPI as INIT
 de-assert. (LAPIC)
Date: Fri, 23 Dec 2011 15:07:21 +0100
Message-ID: <1324649241.15135.19.camel@tabernacle.lan>
References: <1324257267-17200-1-git-send-email-js@alien8.de>
	 <20111223104031.GB24308@amt.cnet>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-svY2ufNCzbDfnQQ+kCPw"
Cc: kvm@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail.skyhub.de ([78.46.96.112]:44116 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754345Ab1LWOH1 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 23 Dec 2011 09:07:27 -0500
In-Reply-To: <20111223104031.GB24308@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


--=-svY2ufNCzbDfnQQ+kCPw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fr, 2011-12-23 at 08:40 -0200, Marcelo Tosatti wrote:
> On Mon, Dec 19, 2011 at 02:14:27AM +0100, Julian Stecklina wrote:
> > If the guest programs an IPI with level=3D0 (de-assert) and trig_mode=
=3D0 (edge),
> > it is erroneously treated as INIT de-assert and ignored, but to quote t=
he
> > spec: "For this delivery mode [INIT de-assert], the level flag must be =
set to
> > 0 and trigger mode flag to 1."
>=20
> Yes, the implementation ignores INIT de-assert. Quoting the spec:
>=20
> "(INIT Level De-assert) (Not supported in the Pentium 4 and Intel Xeon
> processors.)"
>=20
> Your patch below is not improving the implementation to be closer to the
> spec: it'll trigger the INIT state initialization with trig_mode =3D=3D 0
> (which is not in accordance with your spec quote above).

I think our code that triggers this does weird things. Let me check
that. Until then ignore that patch and sorry for the noise. :) At least
it seems as if real hardware is interpreting the spec in a slightly
different way...

Regards, Julian


--=-svY2ufNCzbDfnQQ+kCPw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAk70ixkACgkQ2EtjUdW3H9kgTQCgkjlNM0RXktUap5NHkeURe6nJ
6ZIAoMjwm/CYQz4CWwwHtJ/1bcKDp5bV
=jE7K
-----END PGP SIGNATURE-----

--=-svY2ufNCzbDfnQQ+kCPw--