From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] KVM: Don't automatically expose the TSC deadline timer
 in cpuid
Date: Sun, 25 Dec 2011 21:47:31 +0200
Message-ID: <1324842451.3261.11.camel@lappy>
References: <1324818200-15660-1-git-send-email-avi@redhat.com>
	 <1324839608.3261.10.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Alexey Zaytsev <alexey.zaytsev@gmail.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, jinsong.liu@intel.com,
	kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ee0-f46.google.com ([74.125.83.46]:56678 "EHLO
	mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751460Ab1LYTrg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 25 Dec 2011 14:47:36 -0500
Received: by eekc4 with SMTP id c4so10684972eek.19
        for <kvm@vger.kernel.org>; Sun, 25 Dec 2011 11:47:35 -0800 (PST)
In-Reply-To: <1324839608.3261.10.camel@lappy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 2011-12-25 at 21:00 +0200, Sasha Levin wrote:
> On Sun, 2011-12-25 at 15:03 +0200, Avi Kivity wrote:
> > +	if (apic) {
> > +		if (best->ecx & bit(X86_FEATURE_TSC_DEADLINE_TIMER))
> > +			apic->lapic_timer.timer_mode_mask = 3 << 17;
> > +		else
> > +			apic->lapic_timer.timer_mode_mask = 1 << 17;
> > +	}
> 
> Can we change these to be:
> 
> if(...)
> 	apic->lapic_timer.timer_mode_mask = APIC_LVT_TIMER_PERIODIC | APIC_LVT_TIMER_TSCDEADLINE;
> else
> 	apic->lapic_timer.timer_mode_mask = APIC_LVT_TIMER_PERIODIC;

Actually,

apic->lapic_timer.timer_mode_mask = APIC_LVT_TIMER_PERIODIC;
if(...)
	apic->lapic_timer.timer_mode_mask |= APIC_LVT_TIMER_TSCDEADLINE;

-- 

Sasha.