public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: js@alien8.de
To: kvm@vger.kernel.org
Cc: Julian Stecklina <js@alien8.de>
Subject: [PATCH] KVM: Don't mistreat edge-triggered INIT IPI as INIT de-assert. (LAPIC)
Date: Mon, 16 Jan 2012 14:02:20 +0100	[thread overview]
Message-ID: <1326718940-7348-1-git-send-email-js@alien8.de> (raw)
In-Reply-To: <20120116101836.GB7937@amt.cnet>

From: Julian Stecklina <js@alien8.de>

If the guest programs an IPI with level=0 (de-assert) and trig_mode=0 (edge),
it is erroneously treated as INIT de-assert and ignored, but to quote the
spec: "For this delivery mode [INIT de-assert], the level flag must be set to
0 and trigger mode flag to 1."

Signed-off-by: Julian Stecklina <js@alien8.de>
---
 arch/x86/kvm/lapic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index cfdc6e0..3ee1d83 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -433,7 +433,7 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
 		break;
 
 	case APIC_DM_INIT:
-		if (level) {
+		if (!trig_mode || level) {
 			result = 1;
 			vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
 			kvm_make_request(KVM_REQ_EVENT, vcpu);
-- 
1.7.8.3


  reply	other threads:[~2012-01-16 13:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19  1:14 [PATCH] KVM: Don't mistreat edge-triggered INIT IPI as INIT de-assert. (LAPIC) Julian Stecklina
2011-12-23 10:40 ` Marcelo Tosatti
2011-12-23 14:07   ` Julian Stecklina
2012-01-12 17:07   ` Julian Stecklina
2012-01-13 10:52     ` Marcelo Tosatti
2012-01-13 11:46       ` Julian Stecklina
2012-01-16 10:18         ` Marcelo Tosatti
2012-01-16 13:02           ` js [this message]
2012-01-24 11:09             ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326718940-7348-1-git-send-email-js@alien8.de \
    --to=js@alien8.de \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox