From mboxrd@z Thu Jan 1 00:00:00 1970 From: js@alien8.de Subject: [PATCH] KVM: Don't mistreat edge-triggered INIT IPI as INIT de-assert. (LAPIC) Date: Mon, 16 Jan 2012 14:02:20 +0100 Message-ID: <1326718940-7348-1-git-send-email-js@alien8.de> References: <20120116101836.GB7937@amt.cnet> Cc: Julian Stecklina To: kvm@vger.kernel.org Return-path: Received: from mail.skyhub.de ([78.46.96.112]:58790 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753178Ab2APNCp (ORCPT ); Mon, 16 Jan 2012 08:02:45 -0500 In-Reply-To: <20120116101836.GB7937@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: From: Julian Stecklina If the guest programs an IPI with level=0 (de-assert) and trig_mode=0 (edge), it is erroneously treated as INIT de-assert and ignored, but to quote the spec: "For this delivery mode [INIT de-assert], the level flag must be set to 0 and trigger mode flag to 1." Signed-off-by: Julian Stecklina --- arch/x86/kvm/lapic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index cfdc6e0..3ee1d83 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -433,7 +433,7 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode, break; case APIC_DM_INIT: - if (level) { + if (!trig_mode || level) { result = 1; vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED; kvm_make_request(KVM_REQ_EVENT, vcpu); -- 1.7.8.3