From: Kevin Wolf <kwolf@redhat.com>
To: kvm@vger.kernel.org
Cc: kwolf@redhat.com, gleb@redhat.com, joerg.roedel@amd.com,
yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com,
mtosatti@redhat.com
Subject: [PATCH 2/3] KVM: x86 emulator: VM86 segments must have DPL 3
Date: Mon, 23 Jan 2012 17:10:47 +0100 [thread overview]
Message-ID: <1327335048-31925-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1327335048-31925-1-git-send-email-kwolf@redhat.com>
Setting the segment DPL to 0 for at least the VM86 code segment makes
the VM entry fail on VMX.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
arch/x86/kvm/emulate.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 1b98a2c..833969e 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -1243,6 +1243,8 @@ static int load_segment_descriptor(struct x86_emulate_ctxt *ctxt,
seg_desc.type = 3;
seg_desc.p = 1;
seg_desc.s = 1;
+ if (ctxt->mode == X86EMUL_MODE_VM86)
+ seg_desc.dpl = 3;
goto load;
}
--
1.7.6.5
next prev parent reply other threads:[~2012-01-23 16:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 16:10 [PATCH 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-23 16:10 ` [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-01-24 9:52 ` Gleb Natapov
2012-01-24 10:09 ` Kevin Wolf
2012-01-24 10:17 ` Gleb Natapov
2012-01-24 10:38 ` Kevin Wolf
2012-01-24 10:52 ` Gleb Natapov
2012-01-24 11:23 ` Kevin Wolf
2012-01-24 11:25 ` Gleb Natapov
2012-01-24 14:03 ` Joerg Roedel
2012-01-24 14:15 ` Kevin Wolf
2012-01-24 14:16 ` Gleb Natapov
2012-01-24 14:24 ` Kevin Wolf
2012-01-24 16:23 ` Gleb Natapov
2012-01-25 16:00 ` Joerg Roedel
2012-01-25 18:29 ` Gleb Natapov
2012-01-27 12:58 ` Kevin Wolf
2012-01-27 13:34 ` Joerg Roedel
2012-01-27 13:55 ` Kevin Wolf
2012-01-27 14:17 ` Joerg Roedel
2012-01-27 15:02 ` Kevin Wolf
2012-01-27 15:45 ` Gleb Natapov
2012-01-23 16:10 ` Kevin Wolf [this message]
2012-01-23 16:10 ` [PATCH 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-01-24 10:57 ` Gleb Natapov
2012-01-24 11:31 ` Kevin Wolf
2012-01-24 11:37 ` Gleb Natapov
2012-01-24 11:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327335048-31925-3-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox