* [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms
@ 2012-01-31 6:30 Matt Evans
2012-01-31 8:13 ` Pekka Enberg
2012-01-31 13:44 ` Sasha Levin
0 siblings, 2 replies; 3+ messages in thread
From: Matt Evans @ 2012-01-31 6:30 UTC (permalink / raw)
To: KVM list; +Cc: Pekka Enberg, Sasha Levin
Commit d3923126a24212f1e746a84a575dadbd9f259418 added a bunch of
nice error checking around ioevent__init() but the init may gracefully
fail if ioevents simply aren't supported (PPC64 KVM).
This commit adds a new return code for the init -- positive, but
identifiable as 'not success 0'.
Signed-off-by: Matt Evans <matt@ozlabs.org>
---
Sasha, you screwed PPC64! And it took me a month to notice.... hahaha!
tools/kvm/ioeventfd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/kvm/ioeventfd.c b/tools/kvm/ioeventfd.c
index 9133101..f2d5a30 100644
--- a/tools/kvm/ioeventfd.c
+++ b/tools/kvm/ioeventfd.c
@@ -67,7 +67,7 @@ int ioeventfd__init(struct kvm *kvm)
ioeventfd_avail = kvm__supports_extension(kvm, KVM_CAP_IOEVENTFD);
if (!ioeventfd_avail)
- return -ENOSYS;
+ return 1; /* Not fatal, but let caller determine no-go. */
epoll_fd = epoll_create(IOEVENTFD_MAX_EVENTS);
if (epoll_fd < 0)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms
2012-01-31 6:30 [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms Matt Evans
@ 2012-01-31 8:13 ` Pekka Enberg
2012-01-31 13:44 ` Sasha Levin
1 sibling, 0 replies; 3+ messages in thread
From: Pekka Enberg @ 2012-01-31 8:13 UTC (permalink / raw)
To: Matt Evans; +Cc: KVM list, Sasha Levin
On Tue, Jan 31, 2012 at 8:30 AM, Matt Evans <matt@ozlabs.org> wrote:
> Commit d3923126a24212f1e746a84a575dadbd9f259418 added a bunch of
> nice error checking around ioevent__init() but the init may gracefully
> fail if ioevents simply aren't supported (PPC64 KVM).
>
> This commit adds a new return code for the init -- positive, but
> identifiable as 'not success 0'.
>
> Signed-off-by: Matt Evans <matt@ozlabs.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms
2012-01-31 6:30 [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms Matt Evans
2012-01-31 8:13 ` Pekka Enberg
@ 2012-01-31 13:44 ` Sasha Levin
1 sibling, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2012-01-31 13:44 UTC (permalink / raw)
To: Matt Evans; +Cc: KVM list, Pekka Enberg
On Tue, 2012-01-31 at 17:30 +1100, Matt Evans wrote:
>
> Commit d3923126a24212f1e746a84a575dadbd9f259418 added a bunch of
> nice error checking around ioevent__init() but the init may gracefully
> fail if ioevents simply aren't supported (PPC64 KVM).
>
> This commit adds a new return code for the init -- positive, but
> identifiable as 'not success 0'.
>
> Signed-off-by: Matt Evans <matt@ozlabs.org>
> ---
>
> Sasha, you screwed PPC64! And it took me a month to notice.... hahaha!
I only broke it two days ago :)
--
Sasha.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-31 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-31 6:30 [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms Matt Evans
2012-01-31 8:13 ` Pekka Enberg
2012-01-31 13:44 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).