From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] kvm tools: Fix segfault when failing to initialize KVM Date: Wed, 01 Feb 2012 07:48:14 -0500 Message-ID: <1328100494.6697.25.camel@lappy> References: <1328062060-17262-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:42904 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754258Ab2BAMsM (ORCPT ); Wed, 1 Feb 2012 07:48:12 -0500 Received: by iacb35 with SMTP id b35so1465352iac.19 for ; Wed, 01 Feb 2012 04:48:12 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2012-02-01 at 09:05 +0200, Pekka Enberg wrote: > On Tue, 31 Jan 2012, Sasha Levin wrote: > > Might happen when hardware virtualization is not supported. > > > > Reported-by: Ingo Molnar > > Signed-off-by: Sasha Levin > > --- > > tools/kvm/builtin-run.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c > > index 6ded1d2..a67faf8 100644 > > --- a/tools/kvm/builtin-run.c > > +++ b/tools/kvm/builtin-run.c > > @@ -997,6 +997,10 @@ static int kvm_cmd_run_init(int argc, const char **argv) > > } > > > > kvm = kvm__init(dev, hugetlbfs_path, ram_size, guest_name); > > + if (IS_ERR_OR_NULL(kvm)) { > > + r = PTR_ERR(kvm); > > How is this going to work when 'kvm' is NULL? It'd be best if kvm_init() > never returned NULL on error. Actually, it never does, I'm not sure why I put IS_ERR_OR_NULL there. I'll resend that one. -- Sasha.