public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: kvm@vger.kernel.org
Cc: kwolf@redhat.com, gleb@redhat.com, joerg.roedel@amd.com,
	yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com,
	mtosatti@redhat.com
Subject: [PATCH v3 2/4] KVM: x86 emulator: VM86 segments must have DPL 3
Date: Fri,  3 Feb 2012 19:29:23 +0100	[thread overview]
Message-ID: <1328293765-13663-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1328293765-13663-1-git-send-email-kwolf@redhat.com>

Setting the segment DPL to 0 for at least the VM86 code segment makes
the VM entry fail on VMX.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 arch/x86/kvm/emulate.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 7097ca9..144a203 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -1243,6 +1243,8 @@ static int load_segment_descriptor(struct x86_emulate_ctxt *ctxt,
 		seg_desc.type = 3;
 		seg_desc.p = 1;
 		seg_desc.s = 1;
+		if (ctxt->mode == X86EMUL_MODE_VM86)
+			seg_desc.dpl = 3;
 		goto load;
 	}
 
-- 
1.7.6.5


  parent reply	other threads:[~2012-02-03 18:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 18:29 [PATCH v3 0/4] Fix task switches into/out of VM86 Kevin Wolf
2012-02-03 18:29 ` [PATCH v3 1/4] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-02-03 18:29 ` Kevin Wolf [this message]
2012-02-03 18:29 ` [PATCH v3 3/4] KVM: SVM: Fix CPL updates Kevin Wolf
2012-02-05 11:16   ` Gleb Natapov
2012-02-06  9:18     ` Kevin Wolf
2012-02-06  9:57       ` Gleb Natapov
2012-02-06 10:40         ` Kevin Wolf
2012-02-03 18:29 ` [PATCH v3 4/4] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-02-06 10:32   ` Avi Kivity
2012-02-06 10:54     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328293765-13663-3-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox